Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.1 and minor clean up #36

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Support PHP 8.1 and minor clean up #36

merged 2 commits into from
Jun 23, 2022

Conversation

SimonFrings
Copy link
Contributor

This changeset adds support for PHP 8.1 and adds convertDeprecationsToExceptions="true" to the phpunit.xml configuration to make sure we'll see future deprecation notices.

Builds on top of #30.

@SimonFrings SimonFrings changed the title Support PHP 8 and minor clean up Support PHP 8.1 and minor clean up Jun 23, 2022
@SimonFrings SimonFrings force-pushed the php8 branch 2 times, most recently from e3a9d1f to f71621d Compare June 23, 2022 10:29
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v1.3.0 milestone Jun 23, 2022
@clue clue merged commit cff1c7b into clue:1.x Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants