Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate UriInterface for request methods, use URL strings instead #174

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

clue
Copy link
Owner

@clue clue commented Jul 2, 2020

This simple changeset deprecates UriInterface for request methods and suggests using URL strings instead. This is more consistent with using relative URLs when a base URL is applied and also improves API usage by removing unneeded options. The UriInterface provides a __toString() method, so it can simply be casted to string prior to invoking any request methods.

Builds on top of #167, #170 and #173

@clue clue added this to the v2.9.0 milestone Jul 2, 2020
@clue clue merged commit d1fcb44 into clue:master Jul 2, 2020
@clue clue deleted the deprecate-uris branch July 2, 2020 09:25
@clue clue added the easy pick label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant