Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated methods to control options, deprecate withOptions() #172

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

clue
Copy link
Owner

@clue clue commented Jul 1, 2020

This changeset deprecates the generic withOptions() method and adds dedicated methods to control all options:

// old: deprecated
$browser->withOptions(['timeout' => 10]);
$browser->withOptions(['followRedirects' => false]);
$browser->withOptions(['obeySuccessCode' => false]);

// new
$browser->withTimeout(10);
$browser->withFollowRedirects(false);
$browser->withRejectErrorResponse(false);

Supersedes / closes #155, thanks @WyriHaximus for the original version!
Resolves #154
Builds on top of #170

@clue clue added this to the v2.9.0 milestone Jul 1, 2020
Copy link
Contributor

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider replacing array of options with dedicated methods
2 participants