Allow Streaming Request #196
Conversation
…ow to define the own middleware streaming handler.
|
Hey @skydiablo, thanks for opening this up 👍 I talked with @clue multiple times about this topic. In the future we definitely want to have this as part of Framework X in a way that X is handling this for you instead of configuring everything all by yourself. I agree that your suggested changes are an improvement, but considering our longer term vision this could potentially lead to future BC-breaks as we then might remove this behavior again. I also wrote some answers and shared some more links in #190 and #193 regarding this topic. |
|
@skydiablo It's been a while since our last conversation in here and like I said above, I'm not sure if we should merge this as is. This topic came up a few times already, not only in here but also in ReactPHP's HTTP component, see reactphp/http#412, reactphp/http#428 and others. My plan is to open a ticket for this in reactphp/http to discuss possible implementations and approaches. Once this is part of ReactPHP, we can simply use it here in Framework X. This is also why we'll probably revert any temporary solution in the long run which could lead to BC breaks. I really appreciate the time and thoughts you put into this (I really do!) and I invite you to keep using your implementation for the time being. With that said, I think it's best we close this for now as we expect to pick this up in the near future 👍 |
in respect to the underlying http-server component which will not allow to define the own middleware streaming handler. this code will give the opportunity to handle the 64KB request body problem. just assign your own 'StreamingRequestMiddleware' with custom allowed body size.