Merge pull request #268 from clue-labs/dockerfile-syntax

Update documentation for `Dockerfile` syntax to avoid `BuildKit` warnings
clue · Dec 12, 2024 · 8b40d8c · 8b40d8c
2 parents a6be70b + ec79294
commit 8b40d8c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/docs/best-practices/deployment.md b/docs/best-practices/deployment.md
@@ -558,10 +558,10 @@ be achieved by using a `Dockerfile` with the following contents:
     COPY public/ public/
     COPY vendor/ vendor/
 
-    ENV X_LISTEN 0.0.0.0:8080
+    ENV X_LISTEN=0.0.0.0:8080
     EXPOSE 8080
 
-    ENTRYPOINT php public/index.php
+    ENTRYPOINT ["php", "public/index.php"]
     ```
 
 === "Dockerfile for minimal production image"
@@ -589,7 +589,7 @@ be achieved by using a `Dockerfile` with the following contents:
     # COPY src/ src/
     COPY --from=build /app/vendor/ vendor/
 
-    ENV X_LISTEN 0.0.0.0:8080
+    ENV X_LISTEN=0.0.0.0:8080
     EXPOSE 8080
 
     USER nobody:nobody

diff --git a/tests/integration/Dockerfile-basics b/tests/integration/Dockerfile-basics
@@ -5,7 +5,7 @@ WORKDIR /app/
 COPY public/ public/
 COPY vendor/ vendor/
 
-ENV X_LISTEN 0.0.0.0:8080
+ENV X_LISTEN=0.0.0.0:8080
 EXPOSE 8080
 
-ENTRYPOINT php public/index.php
+ENTRYPOINT ["php", "public/index.php"]
diff --git a/tests/integration/Dockerfile-production b/tests/integration/Dockerfile-production
@@ -23,7 +23,7 @@ COPY public/ public/
 # COPY src/ src/
 COPY --from=build /app/vendor/ vendor/
 
-ENV X_LISTEN 0.0.0.0:8080
+ENV X_LISTEN=0.0.0.0:8080
 EXPOSE 8080
 
 USER nobody:nobody