Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize all images and reduce image sizes #137

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented May 8, 2024

This changeset aims to optimize all images and to reduce image resolution to what would be the maximum image resolution at 2x DPR. In particular, this significantly reduces the transferred data from ~6.54 MB to ~3.1 MB, i.e. the previous version is ~2x larger. Additionally the download size for the blog pages are reduced here as well. Despite loading much faster, this should show no visible changes otherwise.

FYI: I also removed the bg.jpg as this picture doesn't seem to be used anymore.

Builds on top of clue/framework-x-website#35, #126 , #117 and others

@SimonFrings SimonFrings requested a review from clue May 8, 2024 14:18
@SimonFrings SimonFrings force-pushed the optimize_images branch 3 times, most recently from 40734bc to 0763d56 Compare June 11, 2024 15:10
www/src/me.jpg Outdated Show resolved Hide resolved
@SimonFrings SimonFrings requested a review from clue June 17, 2024 08:55
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit a330bad into clue:main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants