Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw UnclosedQuotesException on unbalanced quotes #10

Merged
merged 4 commits into from
Dec 18, 2016
Merged

Throw UnclosedQuotesException on unbalanced quotes #10

merged 4 commits into from
Dec 18, 2016

Conversation

clue
Copy link
Owner

@clue clue commented Dec 18, 2016

Throw UnclosedQuotesException on unbalanced quotes which includes getQuotes() and getPosition() accessors.

This is a BC break because this class extends InvalidArgumentException instead of the previous RuntimeException.

@clue clue added this to the v2.0.0 milestone Dec 18, 2016
@clue clue merged commit a48330c into clue:master Dec 18, 2016
@clue clue deleted the quotes branch December 18, 2016 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break new feature
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@clue