-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressed issue causing the tour to break when a particular step is missing #24
Open
tsrivishnu
wants to merge
9
commits into
clu3:master
Choose a base branch
from
tsrivishnu:missing_index
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tsrivishnu thanks for the pull request, I will merge it once i've had a closer look. |
@clu3 sure.. thanks.. |
@clu3 hey, this has been open for quite a long time. |
@tsrivishnu Thanks a lot buddy for reminding. Could you please make it in 1 commit? |
…ng in an object so more can be added later without breaking the API
…ntirely visible, do not scroll to top.\n 2. show data can be gotten from ajax to keep HTML clean \n 3. added a few more options: nextButtonText for a simpler nextButton,prevButtonText,finishButtonText. Those attributes can also be overridded by a specific element's corresponding attribute such as data-bootstro-nextButtonText.\n 4. Added a few function handlers in option: onComplete,onExit.\n 5. options.margin added to keep element nicely visible within a some top margin
next popup with check for next available index rather than just incrementing going to previous popup will also now check for the available previous index rather than just decrementing 1 variable name changed to make it understandable removed unwanted gitignore
@clu3 hey there., I have squashed my four commits into one. You can check. #ec1e022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.,
Here is my suggested solution for issue #5
As I understood the issue is being caused since you were incrementing the index value when the user tries to go to the next popup. So when a particular step is missing, you are shifting to the DOM order which causes the tour popups to jump around without following a order.
What i have done is, I have taken all the steps indexes for the DOM into an array,
and if all the DOM elements are not provided with step, make the order default to follow DOM ordering
So when ever the user tries to go for the next popup, I check over the indexes array to find if the index we are trying is existing, if not, trying for the next available index
so it always will find the next available popup and go in a order rather than jumping around when a step is missing.