upgrade plate; add tailwind; refactor as needed #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverich
force-pushed
the
upgrade-plate
branch
from
ae1775b
to
3f6334d
Compare
cloverich
changed the title
I think because these are all dev dependencies, the imported code will be not imported, or maybe tree shaken out. I don't have a bundle size measurement. Compressed package is ~5mb bigger (99 -> 104mb). Hopefully ok to defer size and performance evaluation to future sprint. |
cloverich
commented
Jan 27, 2024
cloverich
force-pushed
the
upgrade-plate
branch
from
3f6334d
to
cac3b66
Compare
- migrate (many versions) to latest plate and slate versions - extensive refactor to support plate changes - add tailwind and numerous required dependencies to achieve parity with prior implementation - improve link support; default plate version includes a hovering link edit menu similar to my prior link edit menu - remove most of the custom image helpers (prefer plate versions) - remove custom link plugin (prefer plate version)
cloverich
force-pushed
the
upgrade-plate
branch
from
cac3b66
to
562f9e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tl;dr is, the newer versions of plate remove the built-in elements, and include only the "plugins" (headless components). To get the UI, you:
Most of the changes here are in support of the plate migration; I'm unclear at this point what the best practice is around using this library, directory organization, etc. I'm operating under the assumption that we'll use this library for at least some time leading to a proper 1.0 release.
Closes #141