[PLUGIN-1017] Escape column names #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
force-pushed
the
pathc/escape-column-names-cloud-mysql
branch
2 times, most recently
from
fa1425c to
58d2d12
Compare
Added fix for date datatype
psainics
force-pushed
the
pathc/escape-column-names-cloud-mysql
branch
from
58d2d12 to
307d311
Compare
…ssue-dev [PLUGIN-1812] Added fix for date datatype in oracle sink
psainics
force-pushed
the
pathc/escape-column-names-cloud-mysql
branch
from
307d311 to
b8a9f71
Compare
psainics
force-pushed
the
pathc/escape-column-names-cloud-mysql
branch
from
b8a9f71 to
7be2c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape column names
Jira : PLUGIN-1017
Description
If column name is a MySQL reserved keyword say
insertthe query will fail due to incorrect sql syntax.This PR fixes this issue by escaping the column names using back ticks.
Similar column escapes is used in other plugins. Ref CloudSQLPostgreSQLSink
Code change
CloudSQLMySQLSink.javaUnit Tests
CloudSQLMySQLSinkTest.java