Settings ServiceInfo in order to enable the reuse of java-support in other JVM languages #192
Conversation
Fix <dependency> tag
…other JVM languages
java-support/src/main/scala/io/cloudstate/javasupport/impl/EntityDiscoveryImpl.scala
Outdated
Show resolved
Hide resolved
java-support/src/main/scala/io/cloudstate/javasupport/impl/EntityDiscoveryImpl.scala
Show resolved
Hide resolved
|
@viktorklang approved ? |
|
Thanks @sleipnir! :) |
viktorklang
added
enhancement
|
It's nothing! |
| supportLibraryName = BuildInfo.name, | ||
| supportLibraryVersion = BuildInfo.version | ||
| supportLibraryName = config.getString("library.name"), | ||
| supportLibraryVersion = config.getString("library.version") |
There was a problem hiding this comment.
Does it matter that this no longer uses the automatically generated current version for cloudstate-java-support, but is instead fixed in config?
There was a problem hiding this comment.
@pvlugter This exists for another support idiom library (like Kotlin) that uses lib java-support as a base and defines a hocon file reference.conf or application.conf and can overwrite the version of the java library with its own information.
There was a problem hiding this comment.
Sure, understand the usage. But currently published versions of cloudstate-java-support, like 0.4.7, will report their version as 0.4.3 since it's hardcoded in the config. What we want is for the name and version to be overridable in config, but use the generated build info by default. I'll make an update for this.
Enables us to customize the information reported in ServiceInfo