Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove getBlurRelatedEventTarget utility #379

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

avinashbot
Copy link
Member

Description

Pretty light easy fix. This one's a hack needed for React ~16.8 on IE11. The focus implementation was changed in React 17 (facebook/react#3751) anyway. Not a major issue, so this can wait, but it's a nice tiny code delete, and I always love that.

How has this been tested?

Testing it right here in GitHub actions mostly. I gave the components a quick manual once-over, but our existing tests are the only reliable way here.

Documentation changes

[Do the changes include any API documentation changes?]

  • Yes, this change contains documentation changes.
  • No.

Related Links

[Attach any related links/pull request for this change]

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot requested a review from a team as a code owner October 14, 2022 16:03
@avinashbot avinashbot requested review from FlorianDr and removed request for a team October 14, 2022 16:03
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 92.58% // Head: 92.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3b3e4c8) compared to base (385bce1).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   92.58%   92.59%           
=======================================
  Files         558      558           
  Lines       15893    15886    -7     
  Branches     4360     4357    -3     
=======================================
- Hits        14714    14709    -5     
+ Misses       1098     1096    -2     
  Partials       81       81           
Impacted Files Coverage Δ
src/date-range-picker/calendar/index.tsx 79.68% <ø> (ø)
src/internal/components/dropdown-status/index.tsx 97.22% <0.00%> (+5.11%) ⬆️
src/internal/events/index.ts 100.00% <ø> (ø)
src/date-range-picker/calendar/grids/grid.tsx 100.00% <100.00%> (ø)
src/input/internal.tsx 100.00% <100.00%> (ø)
...rc/internal/components/autosuggest-input/index.tsx 95.48% <100.00%> (-0.04%) ⬇️
src/internal/components/button-trigger/index.tsx 100.00% <100.00%> (ø)
src/internal/components/options-list/index.tsx 97.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FlorianDr FlorianDr removed their request for review October 17, 2022 08:32
@avinashbot avinashbot merged commit 2624f3f into main Oct 17, 2022
@avinashbot avinashbot deleted the remove-related-event-hack branch October 17, 2022 09:07
karmanya79 pushed a commit to karmanya79/components that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants