fix(container): Prevent overflowing content #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianDr
commented
Aug 3, 2022
| * to prevent content exceeding the parent container if border-radius is not 0. | ||
| * Stacked containers mirror the parent behavior by having border-radius set to 0. | ||
| */ | ||
| .root.header, |
There was a problem hiding this comment.
This is more specific than the .header and .content selectors above. stylelint enforce the order to be increasing specificity.
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 535 535
Lines 15462 15462
Branches 4254 4254
=======================================
Hits 14284 14284
Misses 1095 1095
Partials 83 83 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Closing PR after the decision to not move forward with this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Include a summary of the changes and the related issue.]
[Also include relevant motivation and context.]
How has this been tested?
[How did you test to verify your changes?]
[How can reviewers test these changes efficiently?]
[Check for unexpected visual regressions, see
CONTRIBUTING.mdfor details.]Documentation changes
[Do the changes include any API documentation changes?]
Related Links
[Attach any related links/pull request for this change]
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.