fix: Remove screen reader specific navigation grid #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed while going through repos that I had a fix for this I hadn't committed... whoops. The board and item palette have a secret grid based on a table layout that's specially accessible only through screen readers. But this has reportedly ended up confusing more people than it has helped. We got this from an internal ticket, but also validated this within our own team and with some accessibility specialists who all agreed it's fine to get rid of.
On the other hand, it will remove the ability for non-visual users to understand the relative positioning of board items, but it's probably really hard to make the grid feel intuitive in the first place without a text-based prelude for keyboard users. Plus, linear/heading navigation has always worked and will continue to work just fine. Fully non-visual screen reader users will presumably see the "drag"/"resize" buttons and not particularly care.
Oh, and one more thing: I have format-on-save enabled, and for some reason whatever VS Code seems to be doing is disagreeing with what ESLint wants, so I made that discrepancy clearer in
.prettierrc
. Same thing abouttsconfig.json
: setting amoduleResolution
of"NodeNext"
is probably not the right answer for a frontend library (either "Bundler" or "Node" seems correct).Related links, issue #, if available: AWSUI-37270
How has this been tested?
I, uh, expected some tests to fail. And uh, none did. So I guess I'm increasing code coverage? 😅
Otherwise, I just manually tested things on VoiceOver.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.