Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade nodejs to version 18 #58

Merged
merged 1 commit into from
Sep 11, 2023
Merged

upgrade nodejs to version 18 #58

merged 1 commit into from
Sep 11, 2023

Conversation

taheramr
Copy link
Member

@taheramr taheramr commented Sep 8, 2023

Issue #, if available:

Description of changes:
Upgrading to the latest LTS version of nodejs 18 since nodejs 16 is getting an end of life.

Ran a test draft PRs for other repos consuming this repo but with this branch instead:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@taheramr taheramr marked this pull request as ready for review September 8, 2023 13:18
@taheramr taheramr requested a review from a team as a code owner September 8, 2023 13:18
@taheramr taheramr requested review from just-boris and removed request for a team September 8, 2023 13:18
@just-boris
Copy link
Member

just-boris commented Sep 8, 2023

I can approve after seeing a green build on your test PR: cloudscape-design/components#1530

We also should try a few more packages, just in case. Let's do the same test PRs in test-utils and browser-test-tools

@taheramr
Copy link
Member Author

taheramr commented Sep 8, 2023

@just-boris added links to other draft PRs with the tests, should be green!

@taheramr taheramr merged commit a25a152 into main Sep 11, 2023
14 checks passed
@taheramr taheramr deleted the chore/upgrade-nodejs branch September 11, 2023 10:49
taheramr added a commit that referenced this pull request Sep 11, 2023
taheramr added a commit that referenced this pull request Sep 11, 2023
taheramr added a commit that referenced this pull request Sep 11, 2023
timogasda pushed a commit that referenced this pull request Oct 16, 2023
just-boris pushed a commit that referenced this pull request Dec 12, 2023
just-boris pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants