Validate API token before passing it on to Ansible #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the token is set to a value that is not a valid HTTP header, Ansible's http client rejects it with an error that reveals the token. This may cause it to be accidentally logged. We now validate the token, to ensure it is a strict subset of valid HTTP header values. It includes a bit more characters than we currently use for our tokens, just in case we change our format.
href
force-pushed
the
denis/token-validation
branch
from
72b635a to
a663e71
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the token is set to a value that is not a valid HTTP header, Ansible's http client rejects it with an error that reveals the token.
This may cause it to be accidentally logged.
We now validate the token, to ensure it is a strict subset of valid HTTP header values. It includes a bit more characters than we currently use for our tokens, just in case we change our format.
See also #106, with credit to @Zellent.