fix: Add DateDayVector support
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spieden thanks for the contribution! Could you also add the code to test date types to https://github.com/cloudquery/plugin-sdk-java/blob/main/lib/src/test/java/io/cloudquery/helper/ArrowHelperTest.java (or to the same test package)? |
|
@candiduslynx Ok done. I removed the |
candiduslynx
approved these changes
Nov 25, 2023
|
@spieden the build for the ci workflow fails |
|
@candiduslynx Hmm, fixed locally but not getting a status back 🤔 |
candiduslynx
changed the title
DateDayVector support
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.13](v0.0.12...v0.0.13) (2023-11-26) ### Bug Fixes * add date types to ArrowHelper ([#141](#141)) ([21e4981](21e4981)) * **deps:** Update dependency com.fasterxml.jackson.core:jackson-annotations to v2.15.3 ([#133](#133)) ([627b49d](627b49d)) * **deps:** Update dependency com.fasterxml.jackson.core:jackson-core to v2.15.3 ([#135](#135)) ([235781d](235781d)) * **deps:** Update dependency com.google.guava:guava to v32.1.3-jre ([#136](#136)) ([eb7b853](eb7b853)) * **deps:** Update dependency gradle to v8.4 ([#137](#137)) ([8675852](8675852)) * **deps:** Update dependency io.grpc:grpc-protobuf to v1.59.0 ([#138](#138)) ([88d3e71](88d3e71)) * **deps:** Update dependency io.grpc:grpc-stub to v1.59.0 ([#140](#140)) ([556b91b](556b91b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Follow-up for #141 Also notice apache/arrow#38891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudquery/cloudquery#15431