Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to Arrow v18 #445

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat: Update to Arrow v18 #445

merged 1 commit into from
Dec 13, 2024

Conversation

erezrokah
Copy link
Member

@erezrokah erezrokah commented Dec 6, 2024

Summary

Part of https://github.com/cloudquery/cloudquery-issues/issues/2806 (internal issue).
Since Arrow Go moved to a new repo, we won't get automatic updates until we migrate manually.

There's https://docs.renovatebot.com/configuration-options/#replacementname but it doesn't support go.mod


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt ./... to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah requested a review from a team as a code owner December 6, 2024 18:03
@erezrokah erezrokah requested review from dcelasun and removed request for a team December 6, 2024 18:03
@github-actions github-actions bot added feat and removed feat labels Dec 6, 2024
@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Dec 13, 2024
@kodiakhq kodiakhq bot merged commit 2cccfa7 into main Dec 13, 2024
12 checks passed
@kodiakhq kodiakhq bot deleted the feat/arrow_v18 branch December 13, 2024 08:47
kodiakhq bot pushed a commit that referenced this pull request Dec 13, 2024
🤖 I have created a release *beep* *boop*
---


## [1.26.0](v1.25.6...v1.26.0) (2024-12-13)


### Features

* Update to Arrow v18 ([#445](#445)) ([2cccfa7](2cccfa7))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Dec 13, 2024
#### Summary

Goes with cloudquery/plugin-pb-go#445

Interesting bit is https://arrow.apache.org/blog/2024/10/23/arrow-go-18.0.0-release/#canonical-extension-types that we might be able to drop our UUID and JSON own extension types, but probably better to do that separately 

Had to do 3ae4778 to get the tests working, followed apache/arrow#43679 as a reference

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to automerge PRs once requirements are met feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants