feat: Validate hub download checksums #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
approved these changes
Nov 13, 2023
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Nov 15, 2023
Get addon downloads to work without making 2 extra api requests but still verifying checksum. ~Needs cloudquery/cloud#660 to be solved/merged first (internal issue)~ Also updates plugin-pb-go to verify the plugin downloads from the hub ([PR](cloudquery/plugin-pb-go#158)) ~We might keep this out and use the AddonWithTeam endpoint which is going to be implemented in the backend soon.~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the
application/jsonrequest and get checksum + location.