-
Notifications
You must be signed in to change notification settings - Fork 2
feat!: Update to SDK V4 & fix infinite loop on transactions #10
Conversation
Update plugin SDK from V3 to V4
Hey @jeromewir thanks for the PR here! It looks good. Few things to be aware of - this repo slipped through the cracks and should've been in archive mode as we don't maintain free plugins anymore (our business is selling plugins while the SDK are open source to enable users to write their own custom sources for private APIs or sources that we don't support yet but users need). Im happy to merge this one but we will be archiving it soon and we have it on our roadmap for our official/paid plugins in the near future. You can either fork and upload it as community plugin to Let me know your preference, Thanks! |
Hey @yevgenypats thanks for the quick reply! No worry, it's all good! Thank you for making Cloudquery, love the tool! |
Thanks @jeromewir !! We will keep you posted here once we have this up and running hopefully pretty shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeromewir we'll go ahead and merge this as it looks great. We'll release the next version as a major bump our how Hub
Co-authored-by: Alex Shcherbakov <[email protected]>
This PR mainly updates the SDK from V3 to V4
I had to update the tests with some handcrafted data as some JSON structs were empty and returning an error in the tests.
Also omitted the checks for
additional_properties
intesting.go
as faker cannot populate it (map[string]interface{}
)While testing against the sandbox, I also noticed an infinite loop on the
transactions
.This is due to the cursor still being set but
hasMore
being updated when there is no more data to fetch.