Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

feat!: Update to SDK V4 & fix infinite loop on transactions #10

Merged
merged 10 commits into from
Jun 14, 2024

Conversation

jeromewir
Copy link
Contributor

This PR mainly updates the SDK from V3 to V4

I had to update the tests with some handcrafted data as some JSON structs were empty and returning an error in the tests.
Also omitted the checks for additional_properties in testing.go as faker cannot populate it (map[string]interface{})

While testing against the sandbox, I also noticed an infinite loop on the transactions.
This is due to the cursor still being set but hasMore being updated when there is no more data to fetch.

@jeromewir jeromewir requested a review from a team as a code owner June 14, 2024 12:20
@jeromewir jeromewir requested review from candiduslynx and removed request for a team June 14, 2024 12:20
@yevgenypats
Copy link
Member

Hey @jeromewir thanks for the PR here! It looks good.

Few things to be aware of - this repo slipped through the cracks and should've been in archive mode as we don't maintain free plugins anymore (our business is selling plugins while the SDK are open source to enable users to write their own custom sources for private APIs or sources that we don't support yet but users need).

Im happy to merge this one but we will be archiving it soon and we have it on our roadmap for our official/paid plugins in the near future. You can either fork and upload it as community plugin to hub.cloudquery.io or if you would like us to take ownership and wait for the official plugin, happy to reimburse/pay for the work on this PR as it was our bad that we forgot to archive it (feel free to ping me at [email protected]).

Let me know your preference, Thanks!

@jeromewir
Copy link
Contributor Author

Hey @yevgenypats thanks for the quick reply!

No worry, it's all good!
Please take ownership, I'll definitely be a paid user once this plugin comes on the hub!
You can close this or merge this as you please.

Thank you for making Cloudquery, love the tool!

@yevgenypats
Copy link
Member

yevgenypats commented Jun 14, 2024

Hey @yevgenypats thanks for the quick reply!

No worry, it's all good! Please take ownership, I'll definitely be a paid user once this plugin comes on the hub! You can close this or merge this as you please.

Thank you for making Cloudquery, love the tool!

Thanks @jeromewir !! We will keep you posted here once we have this up and running hopefully pretty shortly.

Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeromewir we'll go ahead and merge this as it looks great. We'll release the next version as a major bump our how Hub

@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Jun 14, 2024
client/client.go Outdated Show resolved Hide resolved
client/testing.go Outdated Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
erezrokah and others added 2 commits June 14, 2024 17:32
@erezrokah erezrokah merged commit 864ef3f into cloudquery:main Jun 14, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Add to automerge PRs once requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants