feat(main): Add JSON schema for spec #13876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
changed the title
disq
previously approved these changes
Sep 20, 2023
candiduslynx
added a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Sep 20, 2023
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Sep 20, 2023
candiduslynx
changed the title
bbernays
reviewed
Sep 20, 2023
|
What do we expect to happen if we merge this PR? Will specs then be validated using JSONSchema, returning an error if validation fails? |
Yes, exactly |
disq
approved these changes
Sep 22, 2023
candiduslynx
force-pushed
the
feat/gcp_json_schema
branch
from
b64a7e9 to
42dfedc
Compare
candiduslynx
added
automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
🤖 I have created a release *beep* *boop* --- ## [9.6.0](plugins-source-gcp-v9.5.4...plugins-source-gcp-v9.6.0) (2023-09-27) ### This Release has the Following Changes to Tables - Table `gcp_compute_routes` was added ### Features * Add `gcp_compute_routes` tables ([#13957](#13957)) ([d6bb094](d6bb094)) * **main:** Add JSON schema for spec ([#13876](#13876)) ([bda21fc](bda21fc)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.0 ([#13978](#13978)) ([2efdf55](2efdf55)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.2 ([#13988](#13988)) ([aebaddf](aebaddf)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.11.0 ([#14031](#14031)) ([ac7cdc4](ac7cdc4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.8.0 ([#13950](#13950)) ([15b0b69](15b0b69)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.9.0 ([#13960](#13960)) ([f074076](f074076)) * **services:** Update GCP Services ([#14023](#14023)) ([97961dd](97961dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
Follow-up for #13876 Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/codegen#29 - [x] cloudquery/plugin-sdk#1254
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Follow-up for cloudquery#13876 Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/codegen#29 - [x] cloudquery/plugin-sdk#1254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: cloudquery/plugin-sdk#1214