Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sync Run API Token Type #109

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

erezrokah
Copy link
Member

@erezrokah erezrokah commented Jan 19, 2024

Work in progress, opening so I can reference from the SDK and CLI

Goes with https://github.com/cloudquery/cloud/pull/954

@erezrokah erezrokah force-pushed the feat/add_sync_run_token_type branch from 2f5180d to 6ab7de7 Compare January 23, 2024 12:16
@erezrokah erezrokah marked this pull request as ready for review January 23, 2024 12:17
@erezrokah erezrokah requested review from hermanschaaf, disq and mnorbury and removed request for disq and hermanschaaf January 23, 2024 12:17
@erezrokah erezrokah force-pushed the feat/add_sync_run_token_type branch from 6ab7de7 to a610d0f Compare January 23, 2024 14:27
@erezrokah erezrokah merged commit f1bcc50 into main Jan 23, 2024
5 checks passed
@erezrokah erezrokah deleted the feat/add_sync_run_token_type branch January 23, 2024 14:35
kodiakhq bot pushed a commit that referenced this pull request Jan 23, 2024
🤖 I have created a release *beep* *boop*
---


## [1.7.0](v1.6.5...v1.7.0) (2024-01-23)


### Features

* Add Sync Run API Token Type ([#109](#109)) ([f1bcc50](f1bcc50))


### Bug Fixes

* Generate CloudQuery Go API Client from `spec.json` ([#107](#107)) ([3e8e533](3e8e533))
* Generate CloudQuery Go API Client from `spec.json` ([#110](#110)) ([bcf1462](bcf1462))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah added a commit to cloudquery/plugin-sdk that referenced this pull request Jan 23, 2024
#### Summary

<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 -->

Goes with cloudquery/cloudquery-api-go#109

---

Use the following steps to ensure your PR is ready to be reviewed

- [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md)
🧑‍🎓
- [ ] Run `go fmt` to format your code 🖊
- [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint
[here](https://golangci-lint.run/usage/install/#local-installation))
- [ ] Update or add tests 🧪
- [ ] Ensure the status checks below are successful ✅
erezrokah added a commit to cloudquery/cloudquery that referenced this pull request Jan 23, 2024
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 -->

#### Summary

Goes with cloudquery/cloudquery-api-go#109 and
cloudquery/plugin-sdk#1473 to report progress
for managed syncs

<!--
Use the following steps to ensure your PR is ready to be reviewed

- [ ] Read the [contribution
guidelines](https://github.com/cloudquery/cloudquery/blob/main/CONTRIBUTING.md)
🧑‍🎓
- [ ] Run `make lint` to ensure the proposed changes follow the coding
style 🚨 (install golangci-lint
[here](https://golangci-lint.run/usage/install/#local-installation))
- [ ] Run `make test` to ensure the proposed changes pass the tests 🧪
- [ ] If changing a source plugin run `make gen` to ensure docs are up
to date 📝
- [ ] Ensure the status checks below are successful ✅
--->

---------

Co-authored-by: Kemal <[email protected]>
kodiakhq bot pushed a commit that referenced this pull request Mar 15, 2024
Similar to #109

Testing a connection is very similar to running a sync job, just with a different CLI command and permissions.
It needs an API token to be able to download plugins and update the status of the test (it won't have access to update usage and progress line sync run API tokens)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants