Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matching for aws-nuke #93

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Update matching for aws-nuke #93

merged 3 commits into from
Jun 30, 2020

Conversation

osterman
Copy link
Member

what

  • Use proper property per resource type
  • Dry-run on PRs

why

  • Properties are horribly inconsistent (probably due to AWS)
  • Dry-runs are critical to validate PRs

@osterman osterman requested a review from a team as a code owner June 30, 2020 16:31
@osterman osterman requested a review from jamengual June 30, 2020 16:38
jamengual
jamengual reviewed Jun 30, 2020
View reviewed changes
Copy link

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osterman
Copy link
Member Author

@jamengual need a ✅ to merge

@osterman osterman merged commit 4d02425 into master Jun 30, 2020
@osterman osterman deleted the aws-nuke branch June 30, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@johncblandii johncblandii johncblandii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osterman @johncblandii @jamengual