Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow manual kickoff of aws-nuke #119

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Allow manual kickoff of aws-nuke #119

merged 1 commit into from
Jun 29, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jun 29, 2021

what

  • Allow manual kickoff of aws-nuke to delete resources
  • Change scheduled nuke time to noon UTC, which is 4am PST and 5am PDT

why

  • Previous PR only allowed manual kickoff to see if resources needed to be deleted
  • Previous scheduled nuke was during workday in US Pacific time zone, meaning a greater chance of nuking a test underway

@Nuru Nuru added the patch A minor, backward compatible change label Jun 29, 2021
@Nuru Nuru requested review from osterman and aknysh June 29, 2021 02:20
@Nuru Nuru requested a review from a team as a code owner June 29, 2021 02:20
@Nuru Nuru merged commit b6f7d66 into master Jun 29, 2021
@Nuru Nuru deleted the nuke-control branch June 29, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@osterman osterman Awaiting requested review from osterman

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @aknysh