Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
cloudposse · Jan 6, 2025 · 34916c8 · 34916c8
1 parent 1987461
commit 34916c8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/atmos/aws-component-helper/acceptance_test.go b/pkg/atmos/aws-component-helper/acceptance_test.go
@@ -18,7 +18,11 @@ func TestAcceptance(t *testing.T) {
 
 	testFolder, err := files.CopyFolderToTemp("../../../", t.Name(), func(path string) bool { return true })
 	require.NoError(t, err)
-	defer os.RemoveAll(testFolder)
+	defer func() {
+		if err := os.RemoveAll(testFolder); err != nil {
+			t.Errorf("failed to cleanup test folder: %v", err)
+		}
+	}()
 
 	fmt.Printf("running in %s\n", testFolder)
 

diff --git a/pkg/atmos/aws-component-helper/shared.go b/pkg/atmos/aws-component-helper/shared.go
@@ -118,6 +118,10 @@ func getAwsAccountId() (string, error) {
 	if err != nil {
 		return "", err
 	}
+	// Add retries for better reliability
+	cfg.RetryMode = aws.RetryModeAdaptive
+	cfg.RetryMaxAttempts = 3
+
 	stsClient := sts.NewFromConfig(cfg)
 	identity, err := stsClient.GetCallerIdentity(ctx, &sts.GetCallerIdentityInput{})
 	if err != nil {