Run terraform validate in examples/complete

[nitrocode]

what

• Run terraform validate in examples/complete

why

• Allow test/bats to pass in terraform module that require aliased providers
• The providers are configured correctly in the complete example so the validation should run in the correct directory instead of the module repo root

references

• Thanks to @alexjurkiewicz for pointing out that the validation could be run in examples
• Thanks to @lorengordon for pointing out this open ticket configuration_aliases in child module terraform validate fails: Provider configuration not present hashicorp/terraform#28490
• Relevant modules
  • https://github.com/cloudposse/terraform-aws-macie/
  • https://github.com/cloudposse/terraform-aws-firewall-manager/
• https://www.terraform.io/docs/cli/commands/#switching-working-directory-with-chdir

[korenyoni]

Reviewed the underlying problem — makes sense. LGTM.

[Nuru]

@aknysh @korenyoni This PR was wrong and should not have been approved:

1. The command change itself is wrong. terraform validate -chdir=examples/complete does not work in any version of Terraform.
2. The bats tests are already being run in examples/complete via the standard make target. See example.
3. Probably this should have been released as a patch.

[aknysh]

yes, sorry.
This was wrong from the beginning https://github.com/cloudposse/test-harness/blob/master/test/terraform/validate.bats