Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[remote-state] Improve backend compatibility #105

Merged
merged 1 commit into from
Oct 13, 2024
Merged

[remote-state] Improve backend compatibility #105

merged 1 commit into from
Oct 13, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 12, 2024

what

  • Improve remote-state backend compatibility

Rather than trying to parse the backend configuration, as a general rule we now just pass it through to the data source. This provides future-proof compatibility with all backends supported by Terraform and OpenTofu.

why

  • This prevents the need for updates like Add S3-compatible backend for Oracle #99 to provide configuration for future S3 backends, while eliminating compatibility issues like 1.6.0 doesn't work with AWS S3 #102.
  • This also eliminates deprecation warnings caused by forcing configuration to look a certain way.
  • Now, users can manage their own remote state configuration to match their toolset.

references

@Nuru Nuru added the enhancement New feature or request label Oct 12, 2024
@Nuru Nuru requested a review from aknysh October 12, 2024 22:58
@Nuru Nuru requested review from a team as code owners October 12, 2024 22:58
@Nuru
Copy link
Contributor Author

Nuru commented Oct 12, 2024

/terratest

@Nuru Nuru enabled auto-merge (squash) October 12, 2024 23:08
@Nuru Nuru changed the title Improve remote-state backend compatibility [remote-state] Improve backend compatibility Oct 12, 2024
@Nuru Nuru disabled auto-merge October 12, 2024 23:08
@Nuru Nuru enabled auto-merge (squash) October 12, 2024 23:09
aknysh
aknysh approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if any runtime issues might arise, but the code LGTM

@Nuru Nuru merged commit 00ea92d into main Oct 13, 2024
51 checks passed
@Nuru Nuru deleted the compatibility branch October 13, 2024 01:22
@github-actions GitHub Actions
Copy link

These changes were released in v1.8.0.

This was referenced Oct 15, 2024
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.6.0 doesn't work with AWS S3
2 participants
@Nuru @aknysh