Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make github_token optional #9

Merged
merged 2 commits into from
May 25, 2019
Merged

Make github_token optional #9

merged 2 commits into from
May 25, 2019

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented May 24, 2019

what

  • Make github_token optional

why

  • If not provided, can be sourced from the GITHUB_TOKEN environment variable
  • Sourcing from the GITHUB_TOKEN environment variable is useful when the module is provisioned from geodesic or CI/CD that have access to the GITHUB_TOKEN environment variable, which in turn could be sourced from SSM using chamber

@aknysh aknysh requested a review from osterman May 24, 2019 20:49
@aknysh aknysh self-assigned this May 24, 2019
@aknysh aknysh mentioned this pull request May 24, 2019
Closed
@aknysh aknysh merged commit 85b4ee0 into master May 25, 2019
@aknysh aknysh deleted the make-github-token-optional branch May 25, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @osterman