Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default value for webhook_content_type #5

Merged
merged 2 commits into from
Dec 14, 2018
Merged

fix: default value for webhook_content_type #5

merged 2 commits into from
Dec 14, 2018

Conversation

joppa27
Copy link
Contributor

@joppa27 joppa27 commented Dec 13, 2018

fixes #4

osterman
osterman requested changes Dec 13, 2018
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resubmitting. Didn’t want to subject you to the rebuild process. If you are up to it, please see inline comments. Readme is computed dynamically and automatically pulls in descriptions from values.

variables.tf Show resolved Hide resolved
README.md Show resolved Hide resolved
@osterman osterman merged commit 54dfa18 into cloudposse:master Dec 14, 2018
@osterman
Copy link
Member

thanks @joppa27 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eosterman-rms eosterman-rms eosterman-rms left review comments

@osterman osterman osterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

application/json is invalid default value for webhook_content_type
3 participants
@joppa27 @osterman @eosterman-rms