Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context.tf updated to v0.24.1, minimum required Terraform version bumped to 0.13.0 when needed, readme updated #26

Merged
merged 5 commits into from
Feb 5, 2021
Merged

context.tf updated to v0.24.1, minimum required Terraform version bumped to 0.13.0 when needed, readme updated #26

merged 5 commits into from
Feb 5, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Feb 4, 2021

what

  • update context.tf to v0.24.1
  • minimum required Terraform version bumped to 0.13.0
  • readme updated, Bridgecrew compliance badges added

why

  • It allows for setting the letter case of tag names and labels, back compatibility with context v0.22.0 and below
  • we have dropped support for Terraform 0.12
  • To be able see and fix the recommendations from Bridgecrew so we can position our modules as standards compliant

@maximmi maximmi requested review from a team as code owners February 4, 2021 18:40
@maximmi maximmi requested review from jamengual and nitrocode and removed request for a team February 4, 2021 18:40
@maximmi maximmi self-assigned this Feb 4, 2021
@maximmi
Copy link
Contributor Author

maximmi commented Feb 4, 2021

/test all

Nuru
Nuru previously requested changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for updated TF 0.12 compatible version to be published

@mergify
Copy link

mergify bot commented Feb 5, 2021

This pull request is now in conflict. Could you fix it @maximmi? 🙏

@mergify mergify bot dismissed Nuru’s stale review February 5, 2021 05:35

This Pull Request has been updated, so we're dismissing all reviews.

@Nuru
Copy link
Contributor

Nuru commented Feb 5, 2021

/test all

@Nuru Nuru self-requested a review February 5, 2021 05:38
@Nuru
Copy link
Contributor

Nuru commented Feb 5, 2021

/test all

@Nuru
Copy link
Contributor

Nuru commented Feb 5, 2021

/test all

@Nuru Nuru merged commit 1ef4814 into master Feb 5, 2021
@Nuru Nuru deleted the context-24.1 branch February 5, 2021 05:54
@Nuru Nuru mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees

@maximmi maximmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximmi @Nuru @cloudpossebot