feat: allow anonymous access if token not set #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/codefresh run test |
maximmi
approved these changes
Apr 18, 2020
|
Hi @maximmi, can you push a new tag with this change at some point? I'd like to thread it back up all the way into https://github.com/cloudposse/terraform-aws-ecs-web-app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this module is used in the code pipeline module (e.g., in the ECS web app module), the provider fails with bad credentials, even if the pipeline or webhooks are disabled.
By setting anonymous access on the provider configuration when the token is not provided, this problem is avoided.
A longer term fix is probably (as others have suggested) to remove the code pipeline from the web app module.