Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to terraform 0.12 #12

Closed
wants to merge 1 commit into from
Closed

Convert to terraform 0.12 #12

wants to merge 1 commit into from

Conversation

uchiumih
Copy link
Contributor

I fixed a missing conversion of old code to Terraform 0.12.

@uchiumih
Copy link
Contributor Author

I got this warning before fix.

Warning: Quoted references are deprecated

  on .terraform/modules/github_webhooks/main.tf line 24, in resource "github_repository_webhook" "default":
  24:     ignore_changes = ["configuration[0].secret"]

In this context, references are expected literally rather than in quotes.
Terraform 0.11 and earlier required quotes, but quoted references are now
deprecated and will be removed in a future version of Terraform. Remove the
quotes surrounding this reference to silence this warning.

Copy link
Contributor

@maximmi maximmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uchiumih please, rebase PR

@maximmi
Copy link
Contributor

maximmi commented Apr 18, 2020

/codefresh run test

@maximmi
Copy link
Contributor

maximmi commented Apr 18, 2020

@uchiumih please, rebase PR

@uchiumih uchiumih requested a review from maximmi April 19, 2020 14:13
@osterman
Copy link
Member

/test all

@osterman
Copy link
Member

This has been fixed in #18

Thanks for opening the PR! We had some tests that needed fixing for me to get this to work

@osterman osterman closed this Jun 10, 2020
@uchiumih uchiumih deleted the convert_to_tf_0.12 branch June 11, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants