Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #10

Merged
merged 12 commits into from
Oct 29, 2019

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jul 2, 2019

what

  • Port module to Terraform 0.12
  • Pin all providers
  • Add example for testing
  • Add bats tests for the example
  • Add Codefresh badge to point to the test pipeline in terraform-modules project
  • Update README

why

  • Module currently does not work with 0.12. Much easier syntax
  • Better regression control
  • Automatically test the example on every commit and pull request
  • Provision resources on AWS in the test account and check the outputs for the correct values
  • terraform-modules project contains pipelines for all terraform modules

notes

  • terratest is disabled for now until we find a way to provide var.github_token

@aknysh aknysh requested a review from osterman July 2, 2019 18:14
@aknysh aknysh self-assigned this Jul 2, 2019
@aknysh aknysh changed the title TerraConvert to TF 0.12. Add tests. Add Codefresh test pipelineform 0.12 Convert to TF 0.12. Add tests. Add Codefresh test pipelineform 0.12 Jul 2, 2019
@aknysh aknysh changed the title Convert to TF 0.12. Add tests. Add Codefresh test pipelineform 0.12 Convert to TF 0.12. Add tests. Add Codefresh test pipeline Jul 2, 2019
@aknysh aknysh merged commit 31dc1d6 into master Oct 29, 2019
@aknysh aknysh deleted the terraform-0.12 branch October 29, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants