Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add logging configuration as example #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andre-lx
Copy link

@andre-lx andre-lx commented May 6, 2024

what

Include logging configuration on example

why

Using the module did not find any example of using the logging configuration so I had to look at main.tf to build the object.

@andre-lx andre-lx requested review from a team as code owners May 6, 2024 11:34
@andre-lx andre-lx requested review from hans-d and jamengual May 6, 2024 11:34
@mergify mergify bot added the triage Needs triage label May 6, 2024
@joe-niland joe-niland added the no-release Do not create a new release (wait for additional code changes) label May 15, 2024
Comment on lines +424 to +426
resource "aws_cloudwatch_log_group" "logging_cloudwatch_log_group" {
name = "aws-waf-logs-${module.waf.id}"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use null-label consistent in examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes) triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants