Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use KMS encryption #178

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Add ability to use KMS encryption #178

merged 2 commits into from
Jul 4, 2024

Conversation

pazaan
Copy link
Contributor

@pazaan pazaan commented Jul 4, 2024

what

Add the ability to use KMS encryption through the addition of the sse_encryption and kms_master_key_id variables.

why

  • Some business have security policies that require the use of customer-managed keys.
  • As per the statement in KMS encryption #105, the default behavior has been left the same as it currently is.

references

closes #105

Add ability to use KMS encryption
e372d46 
Add the ability to use KMS encyption through the addition of the
`sse_encryption` and `kms_master_key_id` variables.

* Fixes cloudposse#105
@pazaan pazaan requested review from a team as code owners July 4, 2024 05:04
@mergify mergify bot added the triage Needs triage label Jul 4, 2024
Gowiem
Gowiem approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised this hasn't been implemented before! LGTM 👍

@Gowiem
Copy link
Member

Gowiem commented Jul 4, 2024

/terratest

@mergify mergify bot removed the triage Needs triage label Jul 4, 2024
@Gowiem Gowiem added enhancement New feature or request minor New features that do not break anything labels Jul 4, 2024
@Gowiem
Copy link
Member

Gowiem commented Jul 4, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jul 4, 2024

/terratest

@Gowiem Gowiem enabled auto-merge (squash) July 4, 2024 17:05
@Gowiem Gowiem merged commit 01232bd into cloudposse:main Jul 4, 2024
14 checks passed
@Gowiem Gowiem mentioned this pull request Jul 4, 2024
Closed
@pazaan pazaan deleted the kms-encryption branch July 5, 2024 04:52
@github-actions GitHub Actions
Copy link

These changes were released in v1.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
enhancement New feature or request minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KMS encryption
2 participants
@pazaan @Gowiem