Support cross-region replication #128
Conversation
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
|
/test all |
| @@ -0,0 +1,3 @@ | |||
| variable "region" { | |||
| type = string | |||
| version = ">= 1.3" | ||
| source = "hashicorp/aws" | ||
| version = ">= 4.0" | ||
| configuration_aliases = [aws.blue, aws.green] |
There was a problem hiding this comment.
this new syntax is nice, but it generates the error
Error: missing provider provider["registry.terraform.io/hashicorp/aws"].green
and it looks like the issue is not solved yet (adding provider block solves one issue but produces another one)
There was a problem hiding this comment.
I am just going to disable the validate test on the module, since that issue clearly says that validate is not expected to work on child modules.
|
/test all |
| There is therefore no longer a block against unencrypted uploads, since they | ||
| will be immediately encrypted anyway. |
There was a problem hiding this comment.
Doesn't this mean we're no longer enforcing the following?:
"Condition": {
"Bool": {
"aws:SecureTransport": "false"
}
},
If so, some of the compliance checks are going to fail. This means that the object isn't required to be encrypted in transit.
|
This pull request is now in conflict. Could you fix it @Nuru? 🙏 |
|
Closing due to staleness, feel free to reopen and update into a reviewable state. |
what
why
references