Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update terraform terraform-aws-modules/notify-slack/aws to v6 - autoclosed #57

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 18, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
terraform-aws-modules/notify-slack/aws (source) module major 5.6 -> 6.4

Release Notes

terraform-aws-modules/terraform-aws-notify-slack (terraform-aws-modules/notify-slack/aws)

v6.4.0

Compare Source

Features

v6.3.0

Compare Source

Features

v6.2.0

Compare Source

Features

v6.1.2

Compare Source

Bug Fixes
  • Correct assume role permissions for SNS service to assume IAM role (#​220) (dae0c0f)

v6.1.1

Compare Source

Bug Fixes
  • Update CI workflow versions to remove deprecated runtime warnings (#​218) (44edd19)

v6.1.0

Compare Source

Features

v6.0.0

Compare Source

⚠ BREAKING CHANGES
  • Added variable to filter body of message on SNS level and bumped min Terraform version to 1.0 (#​196)
Features
  • Added variable to filter body of message on SNS level and bumped min Terraform version to 1.0 (#​196) (ab660f7)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the auto-update This PR was automatically generated label May 18, 2024
@renovate renovate bot requested review from a team as code owners May 18, 2024 03:19
@renovate renovate bot requested review from johncblandii and nitrocode May 18, 2024 03:19
Copy link

mergify bot commented May 18, 2024

/terratest

@renovate renovate bot force-pushed the renovate/terraform-aws-modules-notify-slack-aws-6.x branch from e62aadb to 6c6b1a1 Compare May 20, 2024 23:14
@renovate renovate bot force-pushed the renovate/terraform-aws-modules-notify-slack-aws-6.x branch from 6c6b1a1 to 97c7457 Compare June 11, 2024 07:50
@rtest12
Copy link
Contributor

rtest12 commented Jun 11, 2024

@johncblandii @nitrocode
Screenshot from 2024-06-11 15-44-30

@kseniyashaydurova
Copy link

@johncblandii @nitrocode Can you pls release this PR?

@renovate renovate bot force-pushed the renovate/terraform-aws-modules-notify-slack-aws-6.x branch from 97c7457 to c970200 Compare June 17, 2024 22:30
@rtest12
Copy link
Contributor

rtest12 commented Jul 3, 2024

@goruha @osterman @johncblandii @gberenice @Gowiem @jamengual @joe-niland @korenyoni @florian0410 @hans-d @RoseSecurity
Could you take a look and release this PR please?

@joe-niland
Copy link
Member

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jul 3, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jul 3, 2024

We need internal Cloud Posse help on this one: Looks like the CloudWatch log group already exists and needs to be cleaned up in the test account.

TestExamplesComplete 2024-07-03T16:47:42Z command.go:121: │ Error: creating CloudWatch Logs Log Group (/aws/lambda/eg-test-sns-default): operation error CloudWatch Logs: CreateLogGroup, https response error StatusCode: 400, RequestID: 1eefd044-082e-4b8e-8c3b-0b3c3f2dd8a8, ResourceAlreadyExistsException: The specified log group already exists
TestExamplesComplete 2024-07-03T16:47:42Z command.go:121: │
TestExamplesComplete 2024-07-03T16:47:42Z command.go:121: │ with module.notify_slack.module.notify_slack.aws_cloudwatch_log_group.lambda[0],
TestExamplesComplete 2024-07-03T16:47:42Z command.go:121: │ on .terraform/modules/notify_slack.notify_slack/main.tf line 46, in resource "aws_cloudwatch_log_group" "lambda":
TestExamplesComplete 2024-07-03T16:47:42Z command.go:121: │ 46: resource "aws_cloudwatch_log_group" "lambda" {
TestExamplesComplete 2024-07-03T16:47:42Z command.go:121: │
TestExamplesComplete 2024-07-03T16:47:42Z command.go:121: ╵

@Gowiem Gowiem added the needs-cloudposse Needs Cloud Posse assistance label Jul 3, 2024
Copy link

mergify bot commented Jul 3, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@rtest12
Copy link
Contributor

rtest12 commented Jul 11, 2024

@Gowiem
Could this take a long time? I'm sorry, I'm just looking at the time the pr is open and I'm worried that Python 3.8 EOL will end earlier.

@gberenice
Copy link
Contributor

gberenice commented Jul 11, 2024

@rtest12 here is a possible fix but it needs to be reviewed #60

@renovate renovate bot changed the title chore(deps): update terraform terraform-aws-modules/notify-slack/aws to v6 chore(deps): update terraform terraform-aws-modules/notify-slack/aws to v6 - autoclosed Jul 11, 2024
@renovate renovate bot closed this Jul 11, 2024
@renovate renovate bot deleted the renovate/terraform-aws-modules-notify-slack-aws-6.x branch July 11, 2024 11:57
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Jul 11, 2024
@Gowiem Gowiem restored the renovate/terraform-aws-modules-notify-slack-aws-6.x branch July 15, 2024 22:12
@Gowiem Gowiem reopened this Jul 15, 2024
@renovate renovate bot closed this Jul 15, 2024
@Gowiem
Copy link
Member

Gowiem commented Jul 15, 2024

/terratest

@renovate renovate bot deleted the renovate/terraform-aws-modules-notify-slack-aws-6.x branch July 15, 2024 22:12
@Gowiem Gowiem restored the renovate/terraform-aws-modules-notify-slack-aws-6.x branch July 15, 2024 22:13
@Gowiem Gowiem reopened this Jul 15, 2024
@renovate renovate bot closed this Jul 15, 2024
@renovate renovate bot deleted the renovate/terraform-aws-modules-notify-slack-aws-6.x branch July 15, 2024 22:14
@Gowiem
Copy link
Member

Gowiem commented Jul 15, 2024

Cmon renovate, stop being a POS.

@Gowiem
Copy link
Member

Gowiem commented Jul 15, 2024

Aha this is me not realizing that this was actually addressed by #60 (Thanks @gberenice!!) -- My bad for the noise folks 😅

This fix can be found in Release https://github.com/cloudposse/terraform-aws-sns-lambda-notify-slack/releases/tag/v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants