Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups and safety checks for upgrade #70

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Cleanups and safety checks for upgrade #70

merged 3 commits into from
Feb 24, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 24, 2022 •
edited
Loading

what

  • Add warning to README and error when force_destroy is true
  • Maintain rule name for lifecycle rule
  • Disable Renovate bot

why

  • If force_destroy is true then an automated, unattended process could cause the S3 bucket to be deleted and all data in it irretrievably lost
  • Remove an unwanted and unneeded source of changes created by upgrading
  • This version should not be updated, it is pinned for compability

references

Closes Renovate PRs:

@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Feb 24, 2022
@Nuru Nuru requested review from a team as code owners February 24, 2022 18:01
@Nuru
Copy link
Contributor Author

Nuru commented Feb 24, 2022

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Feb 24, 2022

/test all

@Nuru Nuru merged commit 2c17ca6 into master Feb 24, 2022
@Nuru Nuru deleted the s3-refactor-id branch February 24, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift Makeshift was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @osterman