Refactor to use s3-bucket module, update in general #66
Conversation
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_VUL_2 Added /test/src/go.sum undefined
|
/test all |
|
/test all |
|
/test all |
Nuru
requested review from
aknysh,
korenyoni,
nitrocode and
osterman
and removed request for
joe-niland and
dylanbannon
|
|
||
| required_providers { | ||
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 3.0" | ||
| version = ">= 3.0, < 4.0" |
There was a problem hiding this comment.
I don't understand. I thought we weren't going to pin provider versions to major releases.
Also, this is more concise, no ?
| version = ">= 3.0, < 4.0" | |
| version = "~> 3.0" |
There was a problem hiding this comment.
Oh ok, so 2 separate releases interesting.
There was a problem hiding this comment.
This is a temporary change to provide a stepping stone to the next version, where the version will be pinned at >= 4.2.
| } | ||
|
|
||
| data "aws_caller_identity" "current" {} | ||
| data "aws_caller_identity" "current" { count = local.enabled ? 1 : 0 } |
There was a problem hiding this comment.
| data "aws_caller_identity" "current" { count = local.enabled ? 1 : 0 } | |
| data "aws_caller_identity" "current" { | |
| count = local.enabled ? 1 : 0 | |
| } |
There was a problem hiding this comment.
I like 1-liners for trivial stuff like this, and terraform fmt approves.
| default = 30 | ||
| description = "Specifies when noncurrent object versions transitions" | ||
| default = 90 | ||
| description = "Specifies when non-current object versions expire" |
There was a problem hiding this comment.
Nit
| description = "Specifies when non-current object versions expire" | |
| description = "Specifies when non-current object versions expire (in days)" |
| variable "noncurrent_version_transition_days" { | ||
| type = number | ||
| default = 30 | ||
| description = "Specifies when noncurrent object versions transition to Glacier Flexible Retrieval" |
There was a problem hiding this comment.
Nit
| description = "Specifies when noncurrent object versions transition to Glacier Flexible Retrieval" | |
| description = "Specifies when noncurrent object versions transition to Glacier Flexible Retrieval (in days)" |
what
mfa_delete< 4.0and disable Renovate bot, closes Prevent using AWS provider v4 due to breaking changes in s3_bucket resources #64why
mfa_deleteenabled requires entering an MFA token for every Terraform operation, which is incompatible with automation. Users requiringmfa_deleteshould either not use Terraform or create their own fork.notes
This is the first of 2 upgrade releases to get this module to support Terraform AWS Provider v4. We are breaking it into 2 releases so that users have the option of upgrading step-by-step rather than all at once. Upgrade instructions are here.