Add blocking of public access to the bucket #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/codefresh run test |
aknysh
reviewed
Apr 2, 2020
main.tf
Outdated
| # https://www.terraform.io/docs/providers/aws/r/s3_bucket_public_access_block.html | ||
| # for the nuances of the blocking options | ||
| resource "aws_s3_bucket_public_access_block" "default" { | ||
| bucket = aws_s3_bucket.default.id |
There was a problem hiding this comment.
Suggested change
| bucket = aws_s3_bucket.default.id | |
| bucket = join("", aws_s3_bucket.default.*.id) |
Because of this error:
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121:
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: on ../../main.tf line 82, in resource "aws_s3_bucket_public_access_block" "default":
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: 82: bucket = aws_s3_bucket.default.id
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121:
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: Because aws_s3_bucket.default has "count" set, its attributes must be accessed
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: on specific instances.
There was a problem hiding this comment.
Sorry about that, I missed a commit when I rebased. All fixed now.
aknysh
requested changes
Apr 2, 2020
There was a problem hiding this comment.
thanks @adamcrews
Please address the comments and rebuild README by executing:
make init
make readme/deps
make readme
adamcrews
force-pushed
the
feature/block_public_acls
branch
from
326b158
to
93458f6
Compare
|
/codefresh run test |
aknysh
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change to the current default behavior, where buckets will be left in a state where they could be made public, and instead makes the buckets block public access by default.