-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocking of public access to the bucket #25
Conversation
/codefresh run test |
main.tf
Outdated
# https://www.terraform.io/docs/providers/aws/r/s3_bucket_public_access_block.html | ||
# for the nuances of the blocking options | ||
resource "aws_s3_bucket_public_access_block" "default" { | ||
bucket = aws_s3_bucket.default.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bucket = aws_s3_bucket.default.id | |
bucket = join("", aws_s3_bucket.default.*.id) |
Because of this error:
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121:
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: on ../../main.tf line 82, in resource "aws_s3_bucket_public_access_block" "default":
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: 82: bucket = aws_s3_bucket.default.id
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121:
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: Because aws_s3_bucket.default has "count" set, its attributes must be accessed
TestExamplesComplete 2020-04-02T00:56:09Z command.go:121: on specific instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, I missed a commit when I rebased. All fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @adamcrews
Please address the comments and rebuild README by executing:
make init
make readme/deps
make readme
326b158
to
93458f6
Compare
/codefresh run test |
This is a change to the current default behavior, where buckets will be left in a state where they could be made public, and instead makes the buckets block public access by default.