-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional transitions to glacier #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @etwillbefine
Looks good, but please rebuild README by executing these commands:
make init
make readme/deps
make readme
It will add the new variables and outputs to README.md
automatically.
In general, any changes to README should be made in README.yaml
(not in this case), and after that executing the commands above will rebuild README.yaml
into README.md
and add all new variables and outputs to README.md
thanks
updated README with enable_glacier_transition |
/codefresh run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @etwillbefine
Thanks for merging. Is there someone else needed or a different PR to wait for before doing the release? |
@etwillbefine sorry for delay, here is the release: https://github.com/cloudposse/terraform-aws-s3-log-storage/releases/tag/0.8.0 |
* make glacier transition optional closes #17 relates to cloudposse/terraform-aws-s3-log-storage#23 * do not enable glacier transition by default * Updated README.md * Executed 'terraform fmt' Co-authored-by: Maxim Mironenko <[email protected]> Co-authored-by: actions-bot <[email protected]>
relates cloudposse/terraform-aws-cloudtrail-s3-bucket#17