optional transitions to glacier #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
previously requested changes
Jan 26, 2020
There was a problem hiding this comment.
thanks @etwillbefine
Looks good, but please rebuild README by executing these commands:
make init
make readme/deps
make readme
It will add the new variables and outputs to README.md automatically.
In general, any changes to README should be made in README.yaml (not in this case), and after that executing the commands above will rebuild README.yaml into README.md and add all new variables and outputs to README.md
thanks
|
updated README with enable_glacier_transition |
|
/codefresh run test |
|
Thanks for merging. Is there someone else needed or a different PR to wait for before doing the release? |
|
@etwillbefine sorry for delay, here is the release: https://github.com/cloudposse/terraform-aws-s3-log-storage/releases/tag/0.8.0 |
maximmi
added a commit
to cloudposse/terraform-aws-cloudtrail-s3-bucket
that referenced
this pull request
Feb 24, 2020
* make glacier transition optional closes #17 relates to cloudposse/terraform-aws-s3-log-storage#23 * do not enable glacier transition by default * Updated README.md * Executed 'terraform fmt' Co-authored-by: Maxim Mironenko <[email protected]> Co-authored-by: actions-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates cloudposse/terraform-aws-cloudtrail-s3-bucket#17