Optionally allow public access to the bucket, default is now to block #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
/codefresh run test |
2 similar comments
|
/codefresh run test |
|
/codefresh run test |
adamcrews
force-pushed
the
feature/block_public_acls
branch
from
94072a9
to
28abd86
Compare
adamcrews
force-pushed
the
feature/block_public_acls
branch
from
28abd86
to
1e011d5
Compare
|
/test all |
|
/test terratest |
|
Looks like there's a legit race-condition introduced by this PR. @adamcrews can you take a look? https://github.com/cloudposse/actions/runs/756273816?check_suite_focus=true |
adamcrews
force-pushed
the
feature/block_public_acls
branch
from
47f9b7b
to
a5b07a8
Compare
|
/test all |
2 similar comments
|
/test all |
|
/test all |
|
/test all |
osterman
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will change the default behavior to now block public access to the bucket. All options can be configured.
This mirrors a recent update to the https://github.com/cloudposse/terraform-aws-s3-log-storage module.
This also supersedes #23