Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flag for disabling parent zone record creation + context.tf upgrade #33

Merged
merged 6 commits into from
Oct 6, 2020

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Sep 19, 2020

what

  • Adds var.parent_zone_record_enabled flag for the ability to disable creating the record on the parent zone.
  • Adds context.tf pattern

why

  • This can be used to support the parent zone being in a different account and creating this record outside of this module.

@Gowiem Gowiem requested review from osterman, aknysh and a team September 19, 2020 15:40
@Gowiem
Copy link
Member Author

Gowiem commented Sep 19, 2020

/test all

2 similar comments
@Gowiem
Copy link
Member Author

Gowiem commented Sep 19, 2020

/test all

@Gowiem
Copy link
Member Author

Gowiem commented Sep 20, 2020

/test all

jamengual
jamengual previously approved these changes Oct 6, 2020
@jamengual
Copy link

@Gowiem can you rebase?

@Gowiem
Copy link
Member Author

Gowiem commented Oct 6, 2020

@jamengual Done! Thanks for the bump.

@Gowiem
Copy link
Member Author

Gowiem commented Oct 6, 2020

/test all

@jamengual jamengual merged commit 0e62612 into master Oct 6, 2020
@jamengual jamengual deleted the parent-zone-record-enabled-flag branch October 6, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants