Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding timeouts while updating,deleting or creating proxy #9

Merged
merged 17 commits into from
Sep 14, 2022
Merged

Adding timeouts while updating,deleting or creating proxy #9

merged 17 commits into from
Sep 14, 2022

Conversation

sunkaraamrutha
Copy link
Contributor

what

  • Currently, proxy deletion timeouts after 60m. This change will let the user specify proxy deletion should the timeout be more than 60m. We have seen this as the constant pain point during our terratests which spin up & delete proxies for tests run.

why

  • We have seen deletion of the RDS proxy that are spun for tests timing out when the proxy infra is destroyed. Tearing down proxy seems to me like a long aws workflow which, sometimes times out when 60m is hit causing our terratests to fail.

references

main.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
sunkaraamrutha and others added 2 commits September 14, 2022 14:22
Co-authored-by: Andriy Knysh <[email protected]>
Co-authored-by: Andriy Knysh <[email protected]>
examples/complete/main.tf Outdated Show resolved Hide resolved
@aknysh
Copy link
Member

aknysh commented Sep 14, 2022

/test all

@sunkaraamrutha sunkaraamrutha requested review from aknysh and removed request for dotCipher and woz5999 September 14, 2022 18:45
@aknysh aknysh merged commit 5a5d540 into cloudposse:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants