Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add count logic #7

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Add count logic #7

merged 3 commits into from
Jul 4, 2022

Conversation

nitrocode
Copy link
Member

what

  • Add count logic

why

  • Best practices

references

@nitrocode nitrocode added the patch A minor, backward compatible change label Jun 29, 2022
@nitrocode nitrocode requested review from a team as code owners June 29, 2022 19:19
@nitrocode
Copy link
Member Author

/test all

korenyoni
korenyoni approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknysh
Copy link
Member

aknysh commented Jul 4, 2022

/test all

@aknysh aknysh merged commit ac5f706 into main Jul 4, 2022
@aknysh aknysh deleted the count branch July 4, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@aknysh aknysh aknysh approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 is a code owner automatically assigned from cloudposse/contributors

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitrocode @aknysh @korenyoni @cloudpossebot