Additional TF 0.13 Fixes #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
jamengual
approved these changes
Aug 18, 2020
rverma-jm
added a commit
to jupiterops/terraform-aws-rds-cluster
that referenced
this pull request
Dec 5, 2020
* Adding timeout for rds cluster resources and defaulting to TF default to 120m (cloudposse#64) Co-authored-by: PePe (Jose) Amengual <[email protected]> * Allow setting `copy_tags_to_snapshot` variable (cloudposse#62) Allow copy_tags_to_snapshot to be set to true via terraform. Signed-off-by: Jon Whitcraft <[email protected]> Co-authored-by: Maxim Mironenko <[email protected]> * Bugfix timeouts (cloudposse#65) * Adding timeout for rds cluster resources and defaulting to TF default to 120m * Fixing bug in timeout config Co-authored-by: PePe (Jose) Amengual <[email protected]> * Allow creation of a cluster without creation of a database (cloudposse#66) * fix(cloudposse#63): instance_count should be independent of autoscaling_min_capacity (cloudposse#67) Co-authored-by: Sumeet Shukla <[email protected]> * Migrate to ChatOps (cloudposse#70) * feat(enable_http_endpoint): added new enable_http_endpoint option for aurora serverless engine (cloudposse#69) * feat(enable_http_endpoint): added new option for aurora serverless related to: cloudposse#54 cloudposse#51 * feat(enable_http_endpoint): corrected default value in docs related to: cloudposse#54 cloudposse#51 * feat: reverted back README.md changes * feat: reverted back README.md changes * feat: generated README.md * Allow user to pass in cluster_identifier (cloudposse#72) * cluster_identifier: Provide ability to supply your own cluster_identifier Change-Id: I63ee15c74e2aa632e0c1cc11fc30ff9d013af4d2 * cluster_identifier: Sort out naming for final snapshot Change-Id: I9f3b103c81b96662f35451d973640fc4d80b8236 * Updated README.md Co-authored-by: Andy Hibbert <[email protected]> Co-authored-by: actions-bot <[email protected]> * 73: Add auto_minor_version_upgrade flag variable (cloudposse#74) * 73: Add auto_minor_version_upgrade flag variable Default to true as per provider. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster_instance#auto_minor_version_upgrade * Updated README.md Co-authored-by: actions-bot <[email protected]> * [AUTOMATED] Update Version Pinning for Terraform to support 0.13 (cloudposse#75) ## What 1. Update Version Pinning for Terraform to support 0.13 ## Why 1. This is a relatively minor update that the CloudPosse module already likely supports. 1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13. * [AUTOMATED] Update terraform-null-label versions to support Terraform 0.13 (cloudposse#76) * Support terraform 0.13 (cloudposse#77) * Update to `context.tf`. Add `primary` and `secondary` cluster resources (cloudposse#79) * Update to `context.tf` * Update to `context.tf` * Update to `context.tf` * Update to `context.tf` * Fix outputs when `enabled=false`. Change Security Group rules from inline to resources (cloudposse#80) * Add IAM role for enhanced monitoring (cloudposse#82) * Update examples * Add IAM role for enhanced monitoring * Add percona xtrabackup import from S3 (cloudposse#84) * Update main.tf * Update variables.tf * Updated README.md * Update variables.tf * Updated README.md * Update variables.tf * Updated README.md * Update variables.tf * Updated README.md * Update main.tf * Update main.tf Co-authored-by: actions-bot <[email protected]> * Fixes DNS prepending var.name to local.cluster_dns_name (cloudposse#88) ## what * DNS was changing when it shouldn't have been, it was the value of: ``` ${var.name}-${local.cluster_dns_name} ``` I think this may have changed in https://github.com/cloudposse/terraform-aws-route53-cluster-hostname/releases/tag/0.6.0 This changes the parameter to `dns_name` and upgrades the version to get a stable DNS record ## why * Fix broken DNS * Serverless: Aurora 2.07.1 MySQL 5.7 and encrypted_storage parameter fix (cloudposse#91) * Aurora serverless is encrypted by default Follow upstream documentation and don't set `storage_encrypted` at all. * Include Aurora 2.07.1 MySQL 5.7 example Also fix minor missing new item in 5.6 example. https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Updates.serverless_2_07_01.html * Add suport for cluster cloning (cloudposse#92) * Fixing incompatibility with snashot_identifier * using upstream names instead Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: PePe (Jose) Amengual <[email protected]> Co-authored-by: Jon Whitcraft <[email protected]> Co-authored-by: Maxim Mironenko <[email protected]> Co-authored-by: Nuru <[email protected]> Co-authored-by: Sumeet Shukla <[email protected]> Co-authored-by: Sumeet Shukla <[email protected]> Co-authored-by: Erik Osterman <[email protected]> Co-authored-by: Mariusz Rajczakowski <[email protected]> Co-authored-by: Andrew Hibbert <[email protected]> Co-authored-by: Andy Hibbert <[email protected]> Co-authored-by: actions-bot <[email protected]> Co-authored-by: Karl <[email protected]> Co-authored-by: Matt Gowie <[email protected]> Co-authored-by: Andriy Knysh <[email protected]> Co-authored-by: nitro <[email protected]> Co-authored-by: Mikael Fridh <[email protected]>
rverma-jm
added a commit
to jupiterops/terraform-aws-rds-cluster
that referenced
this pull request
Dec 9, 2020
* Adding timeout for rds cluster resources and defaulting to TF default to 120m (cloudposse#64) Co-authored-by: PePe (Jose) Amengual <[email protected]> * Allow setting `copy_tags_to_snapshot` variable (cloudposse#62) Allow copy_tags_to_snapshot to be set to true via terraform. Signed-off-by: Jon Whitcraft <[email protected]> Co-authored-by: Maxim Mironenko <[email protected]> * Bugfix timeouts (cloudposse#65) * Adding timeout for rds cluster resources and defaulting to TF default to 120m * Fixing bug in timeout config Co-authored-by: PePe (Jose) Amengual <[email protected]> * Allow creation of a cluster without creation of a database (cloudposse#66) * fix(cloudposse#63): instance_count should be independent of autoscaling_min_capacity (cloudposse#67) Co-authored-by: Sumeet Shukla <[email protected]> * Migrate to ChatOps (cloudposse#70) * feat(enable_http_endpoint): added new enable_http_endpoint option for aurora serverless engine (cloudposse#69) * feat(enable_http_endpoint): added new option for aurora serverless related to: cloudposse#54 cloudposse#51 * feat(enable_http_endpoint): corrected default value in docs related to: cloudposse#54 cloudposse#51 * feat: reverted back README.md changes * feat: reverted back README.md changes * feat: generated README.md * Allow user to pass in cluster_identifier (cloudposse#72) * cluster_identifier: Provide ability to supply your own cluster_identifier Change-Id: I63ee15c74e2aa632e0c1cc11fc30ff9d013af4d2 * cluster_identifier: Sort out naming for final snapshot Change-Id: I9f3b103c81b96662f35451d973640fc4d80b8236 * Updated README.md Co-authored-by: Andy Hibbert <[email protected]> Co-authored-by: actions-bot <[email protected]> * 73: Add auto_minor_version_upgrade flag variable (cloudposse#74) * 73: Add auto_minor_version_upgrade flag variable Default to true as per provider. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster_instance#auto_minor_version_upgrade * Updated README.md Co-authored-by: actions-bot <[email protected]> * [AUTOMATED] Update Version Pinning for Terraform to support 0.13 (cloudposse#75) ## What 1. Update Version Pinning for Terraform to support 0.13 ## Why 1. This is a relatively minor update that the CloudPosse module already likely supports. 1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13. * [AUTOMATED] Update terraform-null-label versions to support Terraform 0.13 (cloudposse#76) * Support terraform 0.13 (cloudposse#77) * Update to `context.tf`. Add `primary` and `secondary` cluster resources (cloudposse#79) * Update to `context.tf` * Update to `context.tf` * Update to `context.tf` * Update to `context.tf` * Fix outputs when `enabled=false`. Change Security Group rules from inline to resources (cloudposse#80) * Add IAM role for enhanced monitoring (cloudposse#82) * Update examples * Add IAM role for enhanced monitoring * Add percona xtrabackup import from S3 (cloudposse#84) * Update main.tf * Update variables.tf * Updated README.md * Update variables.tf * Updated README.md * Update variables.tf * Updated README.md * Update variables.tf * Updated README.md * Update main.tf * Update main.tf Co-authored-by: actions-bot <[email protected]> * Fixes DNS prepending var.name to local.cluster_dns_name (cloudposse#88) ## what * DNS was changing when it shouldn't have been, it was the value of: ``` ${var.name}-${local.cluster_dns_name} ``` I think this may have changed in https://github.com/cloudposse/terraform-aws-route53-cluster-hostname/releases/tag/0.6.0 This changes the parameter to `dns_name` and upgrades the version to get a stable DNS record ## why * Fix broken DNS * Serverless: Aurora 2.07.1 MySQL 5.7 and encrypted_storage parameter fix (cloudposse#91) * Aurora serverless is encrypted by default Follow upstream documentation and don't set `storage_encrypted` at all. * Include Aurora 2.07.1 MySQL 5.7 example Also fix minor missing new item in 5.6 example. https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Updates.serverless_2_07_01.html * Add suport for cluster cloning (cloudposse#92) * Fixing incompatibility with snashot_identifier * using upstream names instead * remove module with db_name * remove module with db_name * remove module with db_name Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: PePe (Jose) Amengual <[email protected]> Co-authored-by: Jon Whitcraft <[email protected]> Co-authored-by: Maxim Mironenko <[email protected]> Co-authored-by: Nuru <[email protected]> Co-authored-by: Sumeet Shukla <[email protected]> Co-authored-by: Sumeet Shukla <[email protected]> Co-authored-by: Erik Osterman <[email protected]> Co-authored-by: Mariusz Rajczakowski <[email protected]> Co-authored-by: Andrew Hibbert <[email protected]> Co-authored-by: Andy Hibbert <[email protected]> Co-authored-by: actions-bot <[email protected]> Co-authored-by: Karl <[email protected]> Co-authored-by: Matt Gowie <[email protected]> Co-authored-by: Andriy Knysh <[email protected]> Co-authored-by: nitro <[email protected]> Co-authored-by: Mikael Fridh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
terraform initerrors using cliwhy