Feat: Add multi_region variable for multi-region CMKs
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -7,6 +7,7 @@ resource "aws_kms_key" "default" { | |||
| description = var.description | |||
| key_usage = var.key_usage | |||
| customer_master_key_spec = var.customer_master_key_spec | |||
| multi_region = var.multi_region | |||
There was a problem hiding this comment.
Ensure AWS CMK rotation is enabled
Resource: aws_kms_key.default | ID: BC_AWS_LOGGING_8
How to Fix
resource "aws_kms_key" "kms_key_1" {
...
is_enabled = true
+ enable_key_rotation = true
}Description
AWS Key Management Service (KMS) allows customers to rotate the backing key. This is where key material is stored within the KMS, and tied to the key ID of the Customer Created customer master key (CMK). The backing key is used to perform cryptographic operations such as encryption and decryption. Automated key rotation currently retains all prior backing keys, allowing decryption of encrypted data to take place transparently.We recommend you enable CMK key rotation to help reduce the potential impact of a compromised key. Data encrypted with a new key cannot be accessed with a previous key, that may have been exposed.
Benchmarks
- PCI-DSS V3.2 3
- ISO27001 A.10.1.2
- CIS AWS V1.2 2.8
- PCI-DSS V3.2.1 3.6.4
- FEDRAMP (MODERATE) SC-12
- CIS AWS V1.3 3.8
| Path | Resource | Connecting Attribute |
|---|---|---|
| /main.tf | aws_kms_alias.default | target_key_id |
|
/test all |
| @@ -7,6 +7,7 @@ resource "aws_kms_key" "default" { | |||
| description = var.description | |||
| key_usage = var.key_usage | |||
| customer_master_key_spec = var.customer_master_key_spec | |||
| multi_region = var.multi_region | |||
There was a problem hiding this comment.
Ensure AWS CMK rotation is enabled
Resource: aws_kms_key.default | ID: BC_AWS_LOGGING_8
How to Fix
resource "aws_kms_key" "kms_key_1" {
...
is_enabled = true
+ enable_key_rotation = true
}Description
AWS Key Management Service (KMS) allows customers to rotate the backing key. This is where key material is stored within the KMS, and tied to the key ID of the Customer Created customer master key (CMK). The backing key is used to perform cryptographic operations such as encryption and decryption. Automated key rotation currently retains all prior backing keys, allowing decryption of encrypted data to take place transparently.We recommend you enable CMK key rotation to help reduce the potential impact of a compromised key. Data encrypted with a new key cannot be accessed with a previous key, that may have been exposed.
Benchmarks
- PCI-DSS V3.2 3
- ISO27001 A.10.1.2
- CIS AWS V1.2 2.8
- PCI-DSS V3.2.1 3.6.4
- FEDRAMP (MODERATE) SC-12
- CIS AWS V1.3 3.8
| Path | Resource | Connecting Attribute |
|---|---|---|
| /main.tf | aws_kms_alias.default | target_key_id |
osterman
approved these changes
Nov 5, 2021
korenyoni
reviewed
Nov 5, 2021
korenyoni
changed the title
multi_region variable for multi-region CMKs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references