Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update context.tf, run make github/init, drop Terraform 0.12 support #28

Merged
merged 6 commits into from
Aug 31, 2021
Merged

Chore: update context.tf, run make github/init, drop Terraform 0.12 support #28

merged 6 commits into from
Aug 31, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Aug 31, 2021 •
edited
Loading

what

  • Update context.tf to that of null-label:0.25.0
  • Run make github/init.
  • drop Terraform 0.12 support.

why

  • The auto-context job was disabled because this repository was inactive for 90 days. This manually updates context.tf as it allows for the new tenant label.
  • make github/init updates GitHub Actions Workflow files to their latest reference counterparts.
  • validation rules were introduced in Terraform 0.13 and are used in the latest context.tf distribution. This PR drops support for Terraform 0.12 and below in order to enable updating to the latest context.tf distribution.

references

@korenyoni korenyoni added the patch A minor, backward compatible change label Aug 31, 2021
@korenyoni korenyoni requested review from a team as code owners August 31, 2021 21:31
@korenyoni
Copy link
Member Author

/test all

@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni changed the title Chore: update context.tf, run make github/init Chore: update context.tf, run make github/init, drop Terraform 0.12 support Aug 31, 2021
@korenyoni korenyoni added minor New features that do not break anything and removed patch A minor, backward compatible change labels Aug 31, 2021
@korenyoni
Copy link
Member Author

Adding the minor label because this change is technically not backwards compatible (drops Terraform 0.12 support).

@korenyoni korenyoni requested review from aknysh and osterman August 31, 2021 22:02
@korenyoni korenyoni merged commit 3a09d1c into master Aug 31, 2021
@korenyoni korenyoni deleted the chore/update-context branch August 31, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@osterman osterman osterman approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korenyoni @osterman @nitrocode @cloudpossebot