Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add variables key_usage and customer_master_key_spec #27

Merged
merged 2 commits into from
Mar 24, 2021
Merged

feat: add variables key_usage and customer_master_key_spec #27

merged 2 commits into from
Mar 24, 2021

Conversation

syphernl
Copy link
Contributor

@syphernl syphernl commented Mar 16, 2021 •
edited
Loading

what

  • Added optional variables key_usage and customer_master_key_spec
  • Updated GitHub configs

why

  • To be able to use the created KMS key with DNSSEC in Route53. The defaults remain unchanged.

references

@syphernl syphernl requested review from a team as code owners March 16, 2021 09:12
@syphernl syphernl requested review from joe-niland and woz5999 March 16, 2021 09:12
@syphernl syphernl changed the title feat: add key_usage variable feat: add variables key_usage and customer_master_key_spec Mar 16, 2021
@Gowiem
Copy link
Member

Gowiem commented Mar 16, 2021

/test all

@Gowiem Gowiem added the terraform/0.13 Module requires Terraform 0.13 or later label Mar 16, 2021
@Gowiem
Copy link
Member

Gowiem commented Mar 16, 2021

/test all

@Gowiem Gowiem merged commit e67584f into cloudposse:master Mar 24, 2021
@syphernl syphernl deleted the feat/key_usage branch March 24, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Gowiem approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syphernl @Gowiem @aknysh @nitrocode