-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide canned policies #25
Comments
this sounds soon to me. |
alexjurkiewicz
added a commit
to alexjurkiewicz/terraform-aws-kms-key
that referenced
this issue
Mar 2, 2021
Instead of relying on KMS to generate a default policy, generate one ourselves, and expose some new variables for users to easily modify it. Now users can explicitly specify who (if anyone) should be key admins, users and grantors. Additionally, they can add custom statements to the default policy to simplify adding small grants. Closes cloudposse#25.
alexjurkiewicz
added a commit
to alexjurkiewicz/terraform-aws-kms-key
that referenced
this issue
Mar 4, 2021
Instead of relying on KMS to generate a default policy, generate one ourselves, and expose some new variables for users to easily modify it. Now users can explicitly specify who (if anyone) should be key admins, users and grantors. Additionally, they can add custom statements to the default policy to simplify adding small grants. Closes cloudposse#25.
@alexjurkiewicz This module is still in need of a simple policy system. Any chance of getting PR #26 merged? |
Sorry, I won't work on this further.
…On Sun, 30 Oct 2022 at 18:49, dstrates ***@***.***> wrote:
@alexjurkiewicz <https://github.com/alexjurkiewicz> This module is still
in need of a simple policy system. Any chance of getting PR #26
<#26> merged?
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4U5NRNAEINSPNWP52XALWFYR6ZANCNFSM4YHNFS2A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This module currently creates KMS keys with a policy stating "any IAM user/role can do anything with this key".
If you want a more restrictive policy, you have to write it yourself.
I think it would be valuable for the module to offer some canned policies that can be used instead.
This is a proposal for giving module users more flexible tools for controlling the key policy.
If you like the design, we can discuss the details, and I am interested in implementing it.
Expected Behavior
var.policy
takes precedence over the below. If it is set, the other proposed variables are ignored.var.canned_policy
has a few options, like:aws-service-use
(the key can only be attached to AWS resources, like RDS encryption)var.extra_policy_statements
lets you provide IAM Policy statements that will be appended to the policy. (It works with the default policy, and with all canned policies). For example:The text was updated successfully, but these errors were encountered: